[Example Builds] Fix Jarhell in example build due to version conflict #135598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In test framework we expose org.hamcrest:hamcrest. Transitively junit and the randomized runner expose hamcrest-core transitive dependencies. This makes jarHell task fail as those jars share common class files. We exclude hamcrest core now explicitly as transitive dependency in the generated pom for test framework as we already include a superset of this by having a direct dependency on hamcrest which includes hamcrest-core
breskeby
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Sep 29, 2025
…elastic#135598) * [Example Builds] Fix Jarhell in example build due to version conflict In test framework we expose org.hamcrest:hamcrest. Transitively junit and the randomized runner expose hamcrest-core transitive dependencies. This makes jarHell task fail as those jars share common class files. We exclude hamcrest core now explicitly as transitive dependency in the generated pom for test framework as we already include a superset of this by having a direct dependency on hamcrest which includes hamcrest-core * Cleanup * Rework excluded transitive dependencies
This was referenced Sep 29, 2025
Merged
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Sep 29, 2025
…elastic#135598) * [Example Builds] Fix Jarhell in example build due to version conflict In test framework we expose org.hamcrest:hamcrest. Transitively junit and the randomized runner expose hamcrest-core transitive dependencies. This makes jarHell task fail as those jars share common class files. We exclude hamcrest core now explicitly as transitive dependency in the generated pom for test framework as we already include a superset of this by having a direct dependency on hamcrest which includes hamcrest-core * Cleanup * Rework excluded transitive dependencies
💔 Backport failed
You can use sqren/backport to manually backport by running |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 29, 2025
…#135598) (#135647) * [Example Builds] Fix Jarhell in example build due to version conflict In test framework we expose org.hamcrest:hamcrest. Transitively junit and the randomized runner expose hamcrest-core transitive dependencies. This makes jarHell task fail as those jars share common class files. We exclude hamcrest core now explicitly as transitive dependency in the generated pom for test framework as we already include a superset of this by having a direct dependency on hamcrest which includes hamcrest-core * Cleanup * Rework excluded transitive dependencies
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 29, 2025
…#135598) (#135646) * [Example Builds] Fix Jarhell in example build due to version conflict In test framework we expose org.hamcrest:hamcrest. Transitively junit and the randomized runner expose hamcrest-core transitive dependencies. This makes jarHell task fail as those jars share common class files. We exclude hamcrest core now explicitly as transitive dependency in the generated pom for test framework as we already include a superset of this by having a direct dependency on hamcrest which includes hamcrest-core * Cleanup * Rework excluded transitive dependencies
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Sep 30, 2025
…elastic#135598) * [Example Builds] Fix Jarhell in example build due to version conflict In test framework we expose org.hamcrest:hamcrest. Transitively junit and the randomized runner expose hamcrest-core transitive dependencies. This makes jarHell task fail as those jars share common class files. We exclude hamcrest core now explicitly as transitive dependency in the generated pom for test framework as we already include a superset of this by having a direct dependency on hamcrest which includes hamcrest-core * Cleanup * Rework excluded transitive dependencies (cherry picked from commit 10f8536) # Conflicts: # test/framework/build.gradle
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Sep 30, 2025
…elastic#135598) * [Example Builds] Fix Jarhell in example build due to version conflict In test framework we expose org.hamcrest:hamcrest. Transitively junit and the randomized runner expose hamcrest-core transitive dependencies. This makes jarHell task fail as those jars share common class files. We exclude hamcrest core now explicitly as transitive dependency in the generated pom for test framework as we already include a superset of this by having a direct dependency on hamcrest which includes hamcrest-core * Cleanup * Rework excluded transitive dependencies (cherry picked from commit 10f8536) # Conflicts: # test/framework/build.gradle
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
breskeby
added a commit
that referenced
this pull request
Sep 30, 2025
…#135598) (#135669) * [Example Builds] Fix Jarhell in example build due to version conflict In test framework we expose org.hamcrest:hamcrest. Transitively junit and the randomized runner expose hamcrest-core transitive dependencies. This makes jarHell task fail as those jars share common class files. We exclude hamcrest core now explicitly as transitive dependency in the generated pom for test framework as we already include a superset of this by having a direct dependency on hamcrest which includes hamcrest-core * Cleanup * Rework excluded transitive dependencies (cherry picked from commit 10f8536) # Conflicts: # test/framework/build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In test framework we expose org.hamcrest:hamcrest. Transitively junit and the randomized runner
expose hamcrest-core transitive dependencies. This makes jarHell task fail as those jars share
common class files.
We exclude hamcrest core now explicitly as transitive dependency in the generated pom for
test framework as we already include a superset of this by having a direct dependency on
hamcrest which includes hamcrest-core